Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #494: Moved from WASM to ServerSide #497

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix #494: Moved from WASM to ServerSide #497

merged 3 commits into from
Feb 21, 2024

Conversation

antoineatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #494

WebApp technology moved from Blazor WebAssembly to Blazor Server.

Remark : A deployed WebApp won't be allowed to reach a CDP4-Comet server that is hosted locally !

@antoineatstariongroup antoineatstariongroup self-assigned this Jan 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
1 Security Hotspot
77.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@antoineatstariongroup
Copy link
Contributor Author

@jaimeatrhea can you double check that 3DViewer is working fine on this branch?

@jaimeatstariongroup
Copy link
Contributor

@jaimeatrhea can you double check that 3DViewer is working fine on this branch?
Sure I will do it right now

@jaimeatstariongroup
Copy link
Contributor

@antoineatrhea This is what I found:

  1. Now initializing the 3D Viewer throws a couple exceptions complaining about JsInteroperability. No idea why, some research will be needed.
  2. Changing most of the properties work. The Color doesn't

Seems to be working reasonably well. But it will need work in the future.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
1 Security Hotspot
77.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@antoineatstariongroup antoineatstariongroup merged commit 70c640c into development Feb 21, 2024
6 checks passed
@samatstariongroup samatstariongroup deleted the feat/GH494-blazor-server branch February 23, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxatstariongroup lxatstariongroup lxatstariongroup approved these changes

@samatstariongroup samatstariongroup samatstariongroup approved these changes

Assignees

@antoineatstariongroup antoineatstariongroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move from WASM to Balzor-server
4 participants
@antoineatstariongroup @jaimeatstariongroup @samatstariongroup @lxatstariongroup